Skip to content

Add a conditional compilation flag to disable preconditions #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Apr 28, 2023

In some situations, like an IDE that runs SwiftSyntax in process, crashing is the worst possible outcome and it’s preferrable to continue running, possibly accepting a misparse. These use cases can disable preconditions in SwiftSyntax using a conditional compilation flag

rdar://108666839

In some situations, like an IDE that runs SwiftSyntax in process, crashing is the worst possible outcome and it’s preferrable to continue running, possibly accepting a misparse. These use cases can disable preconditions in SwiftSyntax using a conditional compilation flag

rdar://108666839
@ahoppen ahoppen requested a review from bnbarham April 28, 2023 22:52
@ahoppen
Copy link
Member Author

ahoppen commented Apr 28, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Apr 29, 2023

@swift-ci Please test macOS

@ahoppen
Copy link
Member Author

ahoppen commented Apr 29, 2023

@swift-ci Please test Windows

@kimdv
Copy link
Contributor

kimdv commented Apr 29, 2023

@swift-ci Please test macOS

@ahoppen ahoppen merged commit 3c73cc8 into swiftlang:main Apr 29, 2023
@ahoppen ahoppen deleted the ahoppen/disable-precondition branch May 1, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants